Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pandas.DataFrame support in core._PrintResult #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paul-ada
Copy link

@paul-ada paul-ada commented Mar 31, 2023

  • and add HasCustomRepr check in value_types

Issue:
When calling Fire on a function that returns a pd.DataFrame, the _PrintResult function in core.py prints the manual for DataFrames from the pandas Docs to stdout.

if value_types.HasCustomStr(result): doesn't recognize the DataFrame's custom __str__ as it is simply seemingly inherited from the custom __repr__ for DataFrames.
See pandas.core.frame.DataFrame.__repr__ which calls .to_string()).

Due to this, the _PrintResult function displays the DataFrame's helptext.HelpText instead.

This implementation should fix the issue.

Edit: Only seeing now that there is a related issue: #274

@google-cla
Copy link

google-cla bot commented Mar 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dbieber
Copy link
Member

dbieber commented Jan 2, 2024

Thanks for the PR @paul-ada! It may be some time before we process it, but it is already appreciated.

@d33bs d33bs mentioned this pull request Jun 12, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants